Skip to content

[Book][Testing] remove Symfony core testing note#6672

Merged
wouterj merged 1 commit intosymfony:2.7from
xabbuh:pr-6628
Jun 24, 2016
Merged

[Book][Testing] remove Symfony core testing note#6672
wouterj merged 1 commit intosymfony:2.7from
xabbuh:pr-6628

Conversation

@xabbuh
Copy link
Copy Markdown
Member

@xabbuh xabbuh commented Jun 22, 2016

No description provided.

@javiereguiluz
Copy link
Copy Markdown
Member

👍

Some quick questions: does the PHPUnit wrapper used by Symfony itself affect us here? Should we rewrite everything to forget about the regular PHPUnit and explain instead how to use "the Symfony's PHPUnit" ?

@xabbuh
Copy link
Copy Markdown
Member Author

xabbuh commented Jun 22, 2016

No, the chapter itself otherwise is fine. Using the PHPUnit wrapper to test your own application is not necessary. We need it for the core to be able to test everything from our code base (as PHPUnit depends on, for example, symfony/yaml itself).

@javiereguiluz
Copy link
Copy Markdown
Member

OK then.

Status: reviewed.

@wouterj
Copy link
Copy Markdown
Member

wouterj commented Jun 24, 2016

Wanted to do this while merging, seems like I forgot. Thanks Christian!

@wouterj wouterj merged commit 4ac210a into symfony:2.7 Jun 24, 2016
wouterj added a commit that referenced this pull request Jun 24, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[Book][Testing] remove Symfony core testing note

Commits
-------

4ac210a [Book][Testing] remove Symfony core testing note
@xabbuh xabbuh deleted the pr-6628 branch June 24, 2016 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants